Enable/disable get and list suffixes depending on can-i auth
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinnovation
force-pushed
the
jjin/can-i-get
branch
from
202f0d9 to
655fbbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 73.92% 71.70% -2.23%
==========================================
Files 1 1
Lines 629 682 +53
==========================================
+ Hits 465 489 +24
- Misses 164 193 +29 ☔ View full report in Codecov by Sentry. |
jinnovation
commented
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152.
This PR uses the
:inapt-if-notslot intransient-suffixto disable the get and list suffixes onkele-resourcedepending on whether or not the user has permission to get and list the given resource for the given context.