Add the capability to change state strings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strings displayed for validating, invalid and cleared state can be changed
|
up ? |
|
ping ? |
|
@jirutka ? can you merge this please ? |
jirutka
reviewed
Nov 9, 2022
| @@ -53,3 +54,5 @@ complete -c swaylock -l text-ver-color --description "Sets the colo | |||
| complete -c swaylock -l text-wrong-color --description "Sets the color of the text when invalid." | |||
| complete -c swaylock -l tiling -s t --description "Same as --scaling=tile." | |||
| complete -c swaylock -l version -s v --description "Show the version number and quit." | |||
| complete -c swaylock -l verstr --description The string displayed when the password is being verified." | |||
| complete -c swaylock -l wrongstr --description The string displayed when the password is wrong." | |||
There was a problem hiding this comment.
There’s a missing opening quote mark in each description you’ve added.
jirutka
reviewed
Nov 9, 2022
| '(--tiling -t)'{--tiling,-t}'[Same as --scaling=tile]' \ | ||
| '(--version -v)'{--version,-v}'[Show the version number and quit]' \ | ||
| '(--verstr)'--verstr'[The string displayed when the password is being verified.]:string:' \ | ||
| '(--wrongstr)'--wrongstr'[The string displayed when the password is wrong.]:string:' |
There was a problem hiding this comment.
Please never mix formatting and functional changes in a single commit. And don’t introduce any formatting changes here.
|
I’ve reimplemented it in #52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to change different strings used in sway effects.