Fix Sentry DSN #1658
Fix Sentry DSN #1658
Conversation
| @@ -353,7 +353,7 @@ services: | |||
| - MAX_BRIDGE_PARTICIPANTS | |||
| - OCTO_BRIDGE_SELECTION_STRATEGY | |||
| - PROSODY_VISITORS_MUC_PREFIX | |||
| - SENTRY_DSN="${JICOFO_SENTRY_DSN:-0}" | |||
There was a problem hiding this comment.
This removes support for setting individual DSN values.
SENTRY_DSN is the name the environment variable the sentry library enforces to use.
There was a problem hiding this comment.
The variable is read during templating, please see the logging.properties
But yes I will have to look at remapping
| @@ -1,7 +1,9 @@ | |||
| {{ if .Env.SENTRY_DSN | default "0" | toBool }} | |||
| {{ $SENTRY_DSN := .Env.SENTRY_DSN | default .Env.JICOFO_SENTRY_DSN -}} | |||
There was a problem hiding this comment.
This does not help. JICOFO_SENTRY_DSN is not evaluated (as only SENTRY_DSN is)
There was a problem hiding this comment.
I would suggest to just strip the | default "0" | toBool-part.
This is at least working in my environment
There was a problem hiding this comment.
Yes, I think that's best, the problem is remapping, making sure that the value passed by docker-compose is unset
|
As you just changed this PR to beeing a draft I PRd my changes I implemented and tested in my env. I hope you are fine with it. For reference: #1659 |
Actually fix #1655
This supports having individual DSNs