Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create DontFragmentAttribute attribute from a factory #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdubov
Copy link

@sdubov sdubov commented Nov 25, 2021

No description provided.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #243 (2d196ef) into master (64a7ca8) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
+ Coverage     38.60%   38.75%   +0.15%     
- Complexity     1351     1355       +4     
============================================
  Files           178      178              
  Lines         12142    12144       +2     
  Branches       1836     1836              
============================================
+ Hits           4688     4707      +19     
+ Misses         6802     6788      -14     
+ Partials        652      649       -3     
Impacted Files Coverage Δ
...ain/java/org/ice4j/attribute/AttributeFactory.java 42.85% <0.00%> (-0.74%) ⬇️
src/main/java/org/ice4j/stack/TransactionID.java 81.03% <0.00%> (-5.18%) ⬇️
...in/java/org/ice4j/ice/ConnectivityCheckClient.java 55.62% <0.00%> (-2.44%) ⬇️
...in/java/org/ice4j/stack/StunClientTransaction.java 81.55% <0.00%> (-1.95%) ⬇️
src/main/java/org/ice4j/ice/CandidatePair.java 67.91% <0.00%> (-1.50%) ⬇️
src/main/java/org/ice4j/message/Message.java 49.81% <0.00%> (-0.74%) ⬇️
...c/main/java/org/ice4j/pseudotcp/PseudoTCPBase.java 64.16% <0.00%> (+0.31%) ⬆️
.../java/org/ice4j/pseudotcp/PseudoTcpSocketImpl.java 65.99% <0.00%> (+0.57%) ⬆️
src/main/java/org/ice4j/util/PeriodicRunnable.java 75.75% <0.00%> (+1.51%) ⬆️
src/main/java/org/ice4j/ice/Agent.java 56.41% <0.00%> (+1.60%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a7ca8...2d196ef. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants