-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handles case where we overflow void elements. #4
Conversation
Handles more tags and tracks.
We heavily depend on the RandomAccessFile from FileDataWriter. So I suggest dropping DataWriter, always using FileDataWriter, and getting rid of isSeekable. @bgrozev WDYT? |
Well there is some logic behind isSeekable() ... my current changes may break that ... but works for our case though and I have added some tests that cover this. |
Looking at the code that I removed:
Seems that the logic of isSeekable is that if it is not seekable you do not add void element, as you will not be able to seek and come back and fill it. |
ea267fe
to
a6c475f
Compare
… correct src position when coping the end of the file.
141170c
to
f9753ba
Compare
f9753ba
to
fb87ddc
Compare
It was skipping the void data.
for (int i = 0; i < 40; i++) | ||
{ | ||
final MatroskaFileTrack nextTrack = new MatroskaFileTrack(); | ||
nextTrack.setTrackNo(i + 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The +2
is only necessary to make line 135 work? Can we simplify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no idea why it is there. I dropped it.
Handles more tags and tracks.