Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CONTRIBUTING.md #1271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create CONTRIBUTING.md #1271

wants to merge 1 commit into from

Conversation

pranshi112
Copy link

fixes #1208

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@pranshi112
Copy link
Author

I've already done that.

bgrozev
bgrozev reviewed May 26, 2020
View reviewed changes
CONTRIBUTING.md
**Commits**
* Write clear meaningful git commit messages (Do read http://chris.beams.io/posts/git-commit/)
* Make sure your PR's description contains GitHub's special keyword references that automatically close the related issue when the PR is merged. (More info at https://github.com/blog/1506-closing-issues-via-pull-requests )
* When you're submitting a PR for a UI-related issue, it would be really awesome if you add a screenshot of your change or a link to a deployment where it can be tested out along with your PR. It makes it very easy for the reviewers and you'll also get reviews quicker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this copied from somewhere? It doesn't apply here

@pranshi112 pranshi112 closed this May 27, 2020
@pranshi112 pranshi112 reopened this May 27, 2020
@pranshi112
Copy link
Author

Those are general guidelines, so mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrozev bgrozev bgrozev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document contribution requirements
3 participants
@pranshi112 @jitsi-jenkins @bgrozev