Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default file path #2070

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fixed default file path #2070

merged 1 commit into from
Nov 13, 2023

Conversation

dkirov-dev
Copy link
Contributor

@dkirov-dev dkirov-dev commented Nov 11, 2023

Fixed the default value of the parameter filePath for the PcapWriter constructor.
Having a "}" at the end of the file name must have been a typo.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2070 (b47039d) into master (7a4dc8b) will increase coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2070      +/-   ##
============================================
+ Coverage     44.23%   44.26%   +0.03%     
- Complexity     1924     1928       +4     
============================================
  Files           340      340              
  Lines         18879    18880       +1     
  Branches       2592     2593       +1     
============================================
+ Hits           8351     8358       +7     
+ Misses         9663     9658       -5     
+ Partials        865      864       -1     
Files Coverage Δ
.../kotlin/org/jitsi/nlj/transform/node/PcapWriter.kt 0.00% <0.00%> (ø)
...g/jitsi/videobridge/relay/RelayMessageTransport.kt 8.33% <0.00%> (-0.05%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bdb0f...b47039d. Read the comment docs.

@dkirov-dev
Copy link
Contributor Author

The PR is originating from the bloomberg organization fork and is covered by the Bloomberg CCLA for contributions.

@dkirov-dev
Copy link
Contributor Author

@bgrozev , @JonathanLennox how do I get somebody to review a PR for jvb?

@bgrozev
Copy link
Member

bgrozev commented Nov 13, 2023

Thanks for the patch. We generally review all open PRs, but you can always comment here or reach out via email if something is not getting attention.

@bgrozev bgrozev merged commit 814bffd into jitsi:master Nov 13, 2023
3 of 4 checks passed
@dkirov-dev dkirov-dev deleted the pcap-writer-fix branch November 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants