Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reject JSON with duplicate keys #2073

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Nov 22, 2023

No description provided.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2073 (189eb5b) into master (7a4dc8b) will increase coverage by 0.07%.
Report is 3 commits behind head on master.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2073      +/-   ##
============================================
+ Coverage     44.23%   44.30%   +0.07%     
- Complexity     1924     1928       +4     
============================================
  Files           340      340              
  Lines         18879    18881       +2     
  Branches       2592     2593       +1     
============================================
+ Hits           8351     8366      +15     
+ Misses         9663     9650      -13     
  Partials        865      865              
Files Coverage Δ
.../jitsi/videobridge/message/BridgeChannelMessage.kt 67.21% <100.00%> (+4.02%) ⬆️
.../kotlin/org/jitsi/nlj/transform/node/PcapWriter.kt 0.00% <0.00%> (ø)
...g/jitsi/videobridge/relay/RelayMessageTransport.kt 8.33% <0.00%> (-0.05%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814bffd...189eb5b. Read the comment docs.

@bgrozev bgrozev force-pushed the bridge-channel-message-tests branch from 99059b6 to 013cf86 Compare November 22, 2023 15:31
@bgrozev bgrozev force-pushed the bridge-channel-message-tests branch from 013cf86 to 189eb5b Compare November 22, 2023 15:32
@bgrozev bgrozev changed the title bridge channel message tests fix: Reject JSON with duplicate keys Nov 22, 2023
@bgrozev bgrozev merged commit 73fb0cf into jitsi:master Nov 29, 2023
3 of 4 checks passed
@bgrozev bgrozev deleted the bridge-channel-message-tests branch May 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants