task: graceful shutdown only via REST

[aaronkvanmeerten]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73fb0cf) 44.30% compared to head (f9a4ecb) 43.98%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2075      +/-   ##
============================================
- Coverage     44.30%   43.98%   -0.33%     
+ Complexity     1928     1918      -10     
============================================
  Files           340      340              
  Lines         18881    18881              
  Branches       2593     2593              
============================================
- Hits           8366     8305      -61     
- Misses         9650     9724      +74     
+ Partials        865      852      -13     

see 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fb0cf...f9a4ecb. Read the comment docs.

[DanielMcAssey]

Is graceful shutdown not supported by JVB anymore?

[aaronkvanmeerten]

Is graceful shutdown not supported by JVB anymore?

Graceful shutdown is still supported, simply does not require a PID, and no longer needs to wait and kill the JVB. Instead, after being triggered for graceful shutdown via REST, the JVB will watch itself for a minimum number of participants or a timeout, and then exit gracefully itself either way.

This PR is meant to reflect this new behavior, but maintain the functionality of the graceful-shutdown.sh script.