Fix bug that would cause VP9/AV1 simulcast not to be routed properly after a switch. #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
reviewed
Feb 20, 2024
| @@ -228,6 +228,9 @@ class Av1DDAdaptiveSourceProjectionContext( | |||
|
|
|||
| private fun frameIsNewSsrc(frame: Av1DDFrame): Boolean = lastAv1FrameProjection.av1Frame?.matchesSSRC(frame) != true | |||
|
|
|||
| private fun frameIsProjectable(frame: Av1DDFrame): Boolean = | |||
| frameIsProjectable(frame) || frame.index >= lastFrameNumberIndexResumption | |||
There was a problem hiding this comment.
Is this supposed to be frameIsNewSsrc instead to frameIsProjectable?
There was a problem hiding this comment.
You are right, thank you!
bgrozev
reviewed
Feb 20, 2024
| @@ -228,6 +228,9 @@ class Av1DDAdaptiveSourceProjectionContext( | |||
|
|
|||
| private fun frameIsNewSsrc(frame: Av1DDFrame): Boolean = lastAv1FrameProjection.av1Frame?.matchesSSRC(frame) != true | |||
|
|
|||
| private fun frameIsProjectable(frame: Av1DDFrame): Boolean = | |||
| frameIsProjectable(frame) || frame.index >= lastFrameNumberIndexResumption | |||
There was a problem hiding this comment.
This doesn't seem right. Does it need to call frameIsNewSsrc like vp9?
There was a problem hiding this comment.
Damian also caught this...autocomplete error.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2101 +/- ##
============================================
- Coverage 44.23% 44.23% -0.01%
- Complexity 1927 1931 +4
============================================
Files 340 340
Lines 18823 18826 +3
Branches 2580 2580
============================================
+ Hits 8327 8328 +1
Misses 9639 9639
- Partials 857 859 +2
Continue to review full report in Codecov by Sentry.
|
bgrozev
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.