Use JitsiXmppStringprep, update smack #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Apr 23, 2024
bgrozev
commented
- ref: Do not register xmpp extensions for RAW UDP, we only support ICE.
- ref: Remove unused code.
- feat: Use JitsiXmppStringprep
- doc: Fix javadocs.
- ref: Move queue stats out of Videobridge.java.
- ref: Move ulimit check out of Videobridge.java.
- ref: Move videobridgeExpireThread out of Videobridge.java.
* Initialize Smack using the default configuration from jitsi-xmpp-extensions. * Move registering extension providers out of Videobridge.java
| /** | ||
| * Gets statistics for the different `PacketQueue`s that this bridge | ||
| * uses. | ||
| * TODO: is there a better place for this? |
There was a problem hiding this comment.
I think you've answered this TODO?
|
Do you have any reason to think we might need to add a flag for the new stringprep here, like you added in jicofo? |
|
The bridge only sees the JIDs from the brewery and jicofo, I don't see any risk or a reason to disable it. |
JonathanLennox
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.