-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export JVM metrics to prometheus. #2129
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d1c70eb
feat: Export JVM metrics to prometheus.
bgrozev f369c68
squash: More generic GC metrics (G1, ZGC, Shenandoah).
bgrozev 7a67c9e
Add a startup_time metric for detection of restarts.
bgrozev 0f85196
Add metrics for queue drops/exceptions.
bgrozev 4310ef5
squash: Fix comment.
bgrozev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
101 changes: 101 additions & 0 deletions
101
jvb/src/main/kotlin/org/jitsi/videobridge/metrics/JvmMetrics.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/* | ||
* Copyright @ 2024 - present 8x8, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.jitsi.videobridge.metrics | ||
|
||
import com.sun.management.UnixOperatingSystemMXBean | ||
import org.jitsi.config.JitsiConfig | ||
import org.jitsi.metaconfig.config | ||
import org.jitsi.utils.logging2.createLogger | ||
import java.lang.management.ManagementFactory | ||
import org.jitsi.videobridge.metrics.VideobridgeMetricsContainer.Companion.instance as metricsContainer | ||
|
||
class JvmMetrics private constructor() { | ||
val logger = createLogger() | ||
|
||
fun update() { | ||
threadCount.set(ManagementFactory.getThreadMXBean().threadCount.toLong()) | ||
ManagementFactory.getGarbageCollectorMXBeans().forEach { gc -> | ||
if (gc.name.lowercase().contains("g1 young")) { | ||
g1YoungTime.set(gc.collectionTime) | ||
g1YoungCount.set(gc.collectionCount) | ||
} else if (gc.name.lowercase().contains("g1 old")) { | ||
g1OldTime.set(gc.collectionTime) | ||
g1OldCount.set(gc.collectionCount) | ||
} | ||
ManagementFactory.getMemoryPoolMXBeans().toSet().forEach { b -> | ||
if (b.name.lowercase().contains("g1 old")) { | ||
logger.info("${b.name} ${b.memoryManagerNames.joinToString { "," }}....${b.usage}") | ||
g1OldUsage.set(b.usage.used) | ||
g1OldCapacity.set(b.usage.max) | ||
} | ||
} | ||
} | ||
(ManagementFactory.getOperatingSystemMXBean() as? UnixOperatingSystemMXBean)?.let { | ||
openFdCount.set(it.openFileDescriptorCount) | ||
} | ||
} | ||
|
||
val threadCount = metricsContainer.registerLongGauge( | ||
"thread_count", | ||
"Current number of JVM threads." | ||
) | ||
|
||
private val g1YoungCount = metricsContainer.registerLongGauge( | ||
"jvm_g1_young_count", | ||
"Collection count for the G1 young generation." | ||
) | ||
|
||
private val g1YoungTime = metricsContainer.registerLongGauge( | ||
"jvm_g1_young_time", | ||
"Collection time for the young G1 generation." | ||
) | ||
|
||
private val g1OldCount = metricsContainer.registerLongGauge( | ||
"jvm_g1_old_count", | ||
"Collection count for the G1 old generation." | ||
) | ||
|
||
private val g1OldTime = metricsContainer.registerLongGauge( | ||
"jvm_g1_old_time", | ||
"Collection time for the G1 old generation." | ||
) | ||
|
||
private val g1OldCapacity = metricsContainer.registerLongGauge( | ||
"jvm_g1_old_capacity", | ||
"Capacity of the G1 Old memory pool." | ||
) | ||
|
||
private val g1OldUsage = metricsContainer.registerLongGauge( | ||
"jvm_g1_old_usage", | ||
"Usage of the G1 Old memory pool." | ||
) | ||
|
||
private val openFdCount = metricsContainer.registerLongGauge( | ||
"jvm_open_fd_count", | ||
"Number of open file descriptors." | ||
) | ||
|
||
companion object { | ||
val enable: Boolean by config { | ||
"videobridge.stats.jvm.enabled".from(JitsiConfig.newConfig) | ||
} | ||
|
||
val INSTANCE = if (enable) JvmMetrics() else null | ||
fun update() { | ||
INSTANCE?.update() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 0 additions & 29 deletions
29
jvb/src/main/kotlin/org/jitsi/videobridge/metrics/ThreadsMetric.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the order of "G1" and "young" consistent.