-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix vp9 temporal layers count in flexibale mode #2198
fix vp9 temporal layers count in flexibale mode #2198
Conversation
Hi, thanks for your contribution! |
bcc93cd
to
8a00678
Compare
8a00678
to
afd485f
Compare
Can you describe how the browser is set to generate this encoding mode, so I can test? Thanks! |
Before join to conference set this config in browser debug console: config.videoQuality = ['VP9'] |
@splinehip How are you forcing the browser to send only one temporal layer? We always configure 3 temporal layers for VP9 both in simulcast and full SVC mode. |
@jallamsetty1 @JonathanLennox Hi! Please try Chromium 125+ (which enabled flexible mode for encoding by default) |
Just use chrome 125+ and set VP9 codec by client side: |
@splinehip Thanks, I am seeing it on meet.jit.si now but not on my lonely. |
Could you try on yours site use 3 participants in conference, when only 2 participants - clients work through p2p not bridge? |
Yes, I do understand that. My lonely was running a bridge version which is slightly older than the current meet.jit.si version. |
It is reproduced on next version to:
|
Hello, i can confirm this issue exists with VP9 falling to 7-8 fps. |
This shouldn't affect AV1. Setting |
I've set disableSimulcast to true and i get 30fps. However no scalability between filmstrip and large video. Can be a workaround waiting this to be merged. |
I have a more general solution (that doesn't hard-code the assumption that there will be three temporal layers) at #2199. Would you be able to test this? |
@JonathanLennox Hi! I tested your fix - work fine, thank you! |
@splinehip - I pushed some more changes to #2199 which should make it more efficient on the server-side - can you test again so we can be sure? Thanks! |
@JonathanLennox HI! Tested, work fine. Thanks! |
In flexible mode (chrome version 125+) if we have only one temporal layer with id=0, received client rendering video stream in 8 fps only.