Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example scqt #4

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix example scqt #4

merged 2 commits into from
Feb 9, 2023

Conversation

jumerckx
Copy link
Contributor

@jumerckx jumerckx commented Feb 9, 2023

Hello,
This is a really nice project! I've been looking into a sliding constant-Q transform implementation as a reference since I couldn't figure out some things based on the paper solely.
I had to change some variable names and arguments to make the scqt example compile on my machine.

I'm curious what bug you're encountering here, do you already get good results? When I tried implementing scqt in Python I encountered problems with these periodic artifacts where it should just be a clear, straight line...
image

Best wishes,
Jules

I had to change some variable names and arguments to make the scqt example compile on my machine.
@jmerkt
Copy link
Owner

jmerkt commented Feb 9, 2023

Hello Jules,
thanks for reporting these issues and creating this PR!
So far I was only debugging the sliding implementation using my ears and this plugin here, which is still wip.
I guess I have to look into the python bindings again and do some plotting there to reproduce and fix your issue, which sounds very reasonable to do. Could be and issue with block sizes or sample rates I did not test so far, but this is only guessing.
Opened an issue for that: #5

Thanks for fixing the example, I gonna merge it in.

Best regards,
Jonas

@jmerkt jmerkt merged commit 9ba4184 into jmerkt:main Feb 9, 2023
@jumerckx jumerckx deleted the patch-1 branch February 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants