Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a really nice project! I've been looking into a sliding constant-Q transform implementation as a reference since I couldn't figure out some things based on the paper solely.
I had to change some variable names and arguments to make the scqt example compile on my machine.
I'm curious what bug you're encountering here, do you already get good results? When I tried implementing scqt in Python I encountered problems with these periodic artifacts where it should just be a clear, straight line...
Best wishes,
Jules