Merge pull request #1726 from joakim-brannstrom/mutate-fix-analyze-depth

mutate: allow analysis of more complex code

libs/libclang_ast/source/libclang_ast/ast/base_visitor.d

@@ -24,6 +24,11 @@ abstract class Visitor {
     void decr() scope {
     }
 
+    // called on each node to check if it should be visited
+    bool precondition() scope {
+        return true;
+    }
+
     void visit(scope const TranslationUnit) {
     }
 

libs/libclang_ast/source/libclang_ast/ast/tree.d

@@ -63,6 +63,9 @@ struct ClangAST(VisitorT) {
 void accept(VisitorT)(scope const Cursor cursor, scope VisitorT visitor) @safe {
     import clang.Visitor : Visitor;
 
+    if (!visitor.precondition)
+        return;
+
     visitor.incr();
     scope (exit)
         visitor.decr();
@@ -90,6 +93,9 @@ void dispatch(VisitorT)(scope const Cursor cursor, scope VisitorT visitor) @trus
     import libclang_ast.ast.nodes;
     import std.conv : to;
 
+    if (!visitor.precondition)
+        return;
+
     static if (__traits(hasMember, VisitorT, "ignoreCursors")) {
         const h = cursor.toHash;
         if (h in visitor.ignoreCursors) {

news.md

@@ -50,6 +50,8 @@ void fn(int x) {
    compilation errors. All known problems have been fixed which should speedup
    mutation testing alot.
  * Update jquery to v3.7.1 to fix three potential security vulnerabilities.
+ * Allow analysis of more complext code by not discarding the whole AST because
+   some AST branches have a "too high" depth.
 
 # v5.0 Limestone
 

plugin/mutate/source/dextool/plugin/mutate/backend/analyze/pass_clang.d

@@ -393,6 +393,12 @@ final class BaseVisitor : ExtendedVisitor {
         return false;
     }
 
+    override bool precondition() scope @safe {
+        // to avoid infinite recursion, which may occur in e.g. postgresql, block
+        // segfault on 300
+        return indent < 150;
+    }
+
     override void incr() scope @safe {
         ++indent;
         lastDecr.clear;
@@ -1107,12 +1113,6 @@ final class BaseVisitor : ExtendedVisitor {
 
     override void visit(scope const IfStmt v) @trusted {
         mixin(mixinNodeLog!());
-        // to avoid infinite recursion, which may occur in e.g. postgresql, block
-        // segfault on 300
-        if (indent > 100) {
-            throw new Exception("max analyze depth reached (100)");
-        }
-
         auto n = ast.get.make!(analyze.BranchBundle);
         if (isConstExpr(v))
             n.schemaBlacklist = true;