Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of updating with using model.save(update_fields=[...]) for Profile and User models #77

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MAM-SYS
Copy link
Contributor

@MAM-SYS MAM-SYS commented Jul 14, 2021

Hello Friends
First of all, apologize me if it takes too long to send changes for this issue
Here is summary of what i did:
1 - I removed the signal receiver for saving profile automatically
2 - I find all the lines that we are updating profile instance (by user.save()), and change them.so now, we are updating profile instances manually with their update_fields
3 - I also pass the update_fields for User instances in some lines

I checked the code so many times not to miss anything. So if i miss anything, apologize me again
I had to change so many lines for this issue so i understand if you think it's too risky to add these changes without completely testing
So if you think they are useless we can throw them away. I just wanted to take this opportunity to help for this issue
It's All Your Decision..
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants