Skip to content

Commit

Permalink
project: Preserve stderr on upload
Browse files Browse the repository at this point in the history
A previous change captured stderr when uploading git projects. This
change ensures stderr is sent to stderr.

Bug: b/297097597
Change-Id: I8314e1017d2a42b7b655fe43ce3c312d397894ca
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/384134
Reviewed-by: Mike Frysinger <[email protected]>
Commit-Queue: Jason Chang <[email protected]>
Tested-by: Jason Chang <[email protected]>
Reviewed-by: Sam Saccone <[email protected]>
  • Loading branch information
Jason Chang authored and LUCI committed Aug 28, 2023
1 parent 1dbf8b4 commit 1e9f7b9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions project.py
Original file line number Diff line number Diff line change
Expand Up @@ -1182,9 +1182,7 @@ def UploadForReview(
ref_spec = ref_spec + "%" + ",".join(opts)
cmd.append(ref_spec)

GitCommand(
self, cmd, bare=True, capture_stderr=True, verify_command=True
).Wait()
GitCommand(self, cmd, bare=True, verify_command=True).Wait()

if not dryrun:
msg = "posted to %s for %s" % (branch.remote.review, dest_branch)
Expand Down

0 comments on commit 1e9f7b9

Please sign in to comment.