Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame #181

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Blame #181

merged 15 commits into from
Jul 3, 2024

Conversation

pouryafard75
Copy link
Collaborator

Work In Progress

Blame functionality

@tsantalis
Copy link
Collaborator

@pouryafard75
Can we remove the test file for the moment from this PR? It makes the build fail.

@pouryafard75 pouryafard75 force-pushed the blame branch 2 times, most recently from 6abf4cb to 1688339 Compare July 3, 2024 05:27
Copy link
Collaborator

@tsantalis tsantalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed approved.

repository,
commitId,
filePath,
name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pouryafard75
There is no need to call the constructor having the name parameter. You can skip this argument.
You can omit name parameter from all your methods.

@tsantalis tsantalis merged commit da42009 into jodavimehran:master Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants