Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WebRtcSocket::players() available for MultipleChannels sockets #373

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Make WebRtcSocket::players() available for MultipleChannels sockets #373

merged 1 commit into from
Nov 18, 2023

Conversation

aleksa2808
Copy link
Contributor

This PR makes the WebRtcSocket::players() method available for WebRtcSocket<MultipleChannels> types as well.

johanhelsing
johanhelsing approved these changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Thanks!

@johanhelsing johanhelsing changed the title make the WebRtcSocket::players() method available for MultipleChannels sockets Make WebRtcSocket::players() available for MultipleChannels sockets Nov 18, 2023
@johanhelsing johanhelsing added the enhancement New feature or request label Nov 18, 2023
@johanhelsing johanhelsing merged commit b12e109 into johanhelsing:main Nov 18, 2023
12 checks passed
@aleksa2808 aleksa2808 deleted the fix/players-method-multiple-channels branch November 25, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanhelsing johanhelsing johanhelsing approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksa2808 @johanhelsing