Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't run twice on pushes to PR branches #377

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

johanhelsing
Copy link
Owner

@johanhelsing johanhelsing commented Nov 23, 2023

There was a minimal difference between a push and a pull_request PR runs on stale branches, but branches based off of main, it would test exactly the same code twice.

As far as I understand, testing the pull request event is best, since it does a merge first, before testing.

@johanhelsing johanhelsing added the ci Only relevant for CI label Nov 23, 2023
@johanhelsing johanhelsing merged commit 20d4fe3 into main Nov 23, 2023
12 checks passed
@johanhelsing johanhelsing deleted the fix-double-ci branch November 23, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Only relevant for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant