fixes #25 , rebuilds site

johnmackintosh · Sep 20, 2019 · 0ae1853 · 0ae1853
1 parent 18ed515
commit 0ae1853
Show file tree

Hide file tree

Showing 40 changed files with 52 additions and 19 deletions.
diff --git a/R/runcharter.R b/R/runcharter.R
@@ -43,7 +43,7 @@
 #'direction = "above", datecol = "date", grpvar ="grp", yval ="y",
 #' facet_cols = 2,chart_title = "Automated runs analysis",
 #'chart_subtitle = " some runs found", chart_caption = "powered by R",
-#'chart_breaks = " 6 months")
+#'chart_breaks = "6 months")
 #' }
 #'
 #'
@@ -75,7 +75,6 @@ runcharter <- function(df,
          call. = FALSE)
   }
 
-
   # mising arguments
   # df
   if (!length(df)) {
@@ -120,6 +119,12 @@ runcharter <- function(df,
     stop('"Please provide a value for the "yval" argument"')
   }
 
+  # # datecol in wrong format
+  # 
+  # if (is.character(datecol)) {
+  #   stop("The date column is a character vector.
+  #    Please ensure this is in a date / datetime / numeric format")
+  # }
 
   start_date <- NULL
   end_date <- NULL

diff --git a/README.Rmd b/README.Rmd
@@ -81,7 +81,7 @@ runcharter(df = signals,
           line_colr = "#005EB8", # blue
           point_colr ="#005EB8", # blue
           median_colr = "#E87722", # orange
-          sus_fill = "#DB1884") # magenta
+          highlight_fill = "#DB1884") # magenta
 
 ```
 

diff --git a/README.md b/README.md
@@ -64,7 +64,7 @@ runcharter(df = signals,
           line_colr = "#005EB8", # blue
           point_colr ="#005EB8", # blue
           median_colr = "#E87722", # orange
-          sus_fill = "#DB1884") # magenta
+          highlight_fill = "#DB1884") # magenta
 ```
 
 The function will return a plot and a summary table showing the original

diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/articles/index.html b/docs/articles/index.html
diff --git a/docs/articles/man/figures/analysis_off-1.png b/docs/articles/man/figures/analysis_off-1.png
diff --git a/docs/articles/man/figures/both-directions-1.png b/docs/articles/man/figures/both-directions-1.png
diff --git a/docs/articles/man/figures/factor-handling-1.png b/docs/articles/man/figures/factor-handling-1.png
diff --git a/docs/articles/man/figures/med_row-0-1.png b/docs/articles/man/figures/med_row-0-1.png
diff --git a/docs/articles/man/figures/multiple-runs-1.png b/docs/articles/man/figures/multiple-runs-1.png
diff --git a/docs/articles/man/figures/pipe-1.png b/docs/articles/man/figures/pipe-1.png
diff --git a/docs/articles/man/figures/run-below-1.png b/docs/articles/man/figures/run-below-1.png
diff --git a/docs/articles/man/figures/runs-above-1.png b/docs/articles/man/figures/runs-above-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-2-1.png b/docs/articles/man/figures/unnamed-chunk-2-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-3-1.png b/docs/articles/man/figures/unnamed-chunk-3-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-4-1.png b/docs/articles/man/figures/unnamed-chunk-4-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-5-1.png b/docs/articles/man/figures/unnamed-chunk-5-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-6-1.png b/docs/articles/man/figures/unnamed-chunk-6-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-7-1.png b/docs/articles/man/figures/unnamed-chunk-7-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-8-1.png b/docs/articles/man/figures/unnamed-chunk-8-1.png
diff --git a/docs/articles/man/figures/unnamed-chunk-9-1.png b/docs/articles/man/figures/unnamed-chunk-9-1.png
diff --git a/docs/articles/runcharter.html b/docs/articles/runcharter.html
diff --git a/docs/authors.html b/docs/authors.html
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -1,5 +1,5 @@
 pandoc: '2.6'
-pkgdown: 1.4.0
+pkgdown: 1.4.1
 pkgdown_sha: ~
 articles:
   runcharter: runcharter.html

diff --git a/docs/reference/figures/analysis_off-1.png b/docs/reference/figures/analysis_off-1.png
diff --git a/docs/reference/figures/both-directions-1.png b/docs/reference/figures/both-directions-1.png
diff --git a/docs/reference/figures/factor-handling-1.png b/docs/reference/figures/factor-handling-1.png
diff --git a/docs/reference/figures/med_row-0-1.png b/docs/reference/figures/med_row-0-1.png
diff --git a/docs/reference/figures/multiple-runs-1.png b/docs/reference/figures/multiple-runs-1.png
diff --git a/docs/reference/figures/pipe-1.png b/docs/reference/figures/pipe-1.png
diff --git a/docs/reference/figures/run-below-1.png b/docs/reference/figures/run-below-1.png
diff --git a/docs/reference/figures/runs-above-1.png b/docs/reference/figures/runs-above-1.png
diff --git a/docs/reference/index.html b/docs/reference/index.html
diff --git a/docs/reference/pipe.html b/docs/reference/pipe.html
diff --git a/docs/reference/runcharter-1.png b/docs/reference/runcharter-1.png
diff --git a/docs/reference/runcharter.html b/docs/reference/runcharter.html
diff --git a/docs/reference/signals.html b/docs/reference/signals.html
diff --git a/man/runcharter.Rd b/man/runcharter.Rd
diff --git a/tests/testthat/test_errors.R b/tests/testthat/test_errors.R
@@ -107,6 +107,21 @@ throws_error('"Please check and provide values for the "datecol"  and "grpvar" a
   throws_error('"Please check and provide values for the "datecol"  and "yval" arguments"'))
 
 
+  # 
+  # #wrong date format
+  # 
+  # test_that("wrong dateformat causes error",{
+  #   expect_that(runcharter(med_rows = 13,
+  #                          runlength = 9,
+  #                          direction = "both",
+  #                          datecol = as.character("date"),
+  #                          grpvar = "grp",
+  #                          yval = "y"),
+  #               throws_error())
+  # })
+
+
+
   # date , grpvar and yval all missing
 
   expect_that(runcharter(signals,
@@ -153,7 +168,7 @@ expect_that(runcharter(signals,
                        datecol = "date",
                        grpvar = "grp",
                        yval = "y"),
-                       throws_error("None of the groups have enough rows of data beyond the specified baseline period, for the desired runlength.
+throws_error("None of the groups have enough rows of data beyond the specified baseline period, for the desired runlength.
         Please check the values of the med_rows and runlength arguments.
         Currently they exceed the number of rows for each group"))  
 
@@ -182,3 +197,8 @@ test_that("missing df argument causes error", {
 
 
 })
+
+
+
+
+