Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance busy notification #2774

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Enhance busy notification #2774

merged 2 commits into from
Dec 31, 2023

Conversation

caco3
Copy link
Collaborator

@caco3 caco3 commented Dec 28, 2023

Updating the markers and enhancing the contrast is only possible while no round is active.
Until now we simply showed an error and the user had to retry until the round completed.
With this MR, the UI shows an overlay message with the round status and retries automatically:
grafik

@caco3 caco3 requested review from jomjol and Slider0007 December 28, 2023 21:36
@caco3 caco3 marked this pull request as draft December 28, 2023 21:36
@caco3 caco3 marked this pull request as ready for review December 28, 2023 22:17
@Slider0007
Copy link
Collaborator

Slider0007 commented Dec 29, 2023

I did a quick test: Pushing the button at the wrong time (e.g. to early before page is fully loaded) results in a boot loop (This could be potentially independent from this change). But as long you stay on the Alignment marker page, boot loop continues. Only after switching to another page or if not possible anymore, closing the browser tab, system is booting again. I haven't analyized it, but I assume due to the periodic check without device is in correct state, system crashes again and again.

image

image

I (15375) MAIN: Initialization completed successfully

abort() was called at PC 0x401b9ae2 on core 1


Backtrace: 0x40083a3d:0x3ffe3050 0x4008ee21:0x3ffe3070 0x40094e35:0x3ffe3090 0x401b9ae2:0x3ffe3100 0x40199d51:0x3ffe3120 0x40189c67:0x3ffe3140 0x40100d15:0x3ffe3160 0x401026e7:0x3ffe3190 0x400e6a25:0x3ffe33a0 0x400e5838:0x3ffe33e0 0x400e5f7e:0x3ffe3490 0x400e4a18:0x3ffe34b0 0x401cf8fa:0x3ffe34d0 0x400e4b5d:0x3ffe34f0

Just a side note:
From visualization point of view it surely will do the job. Maybe only a slight different text would also do the job with less effort.
image

@Slider0007 Slider0007 removed their request for review December 29, 2023 09:52
@caco3
Copy link
Collaborator Author

caco3 commented Dec 29, 2023

@Slider0007 Thanks for spotting that. I only changed javascript code but it calls the REST API every 5 seconds once the button got pressed. The crash is due to an underlying issue we have. I will try to find it.

There are 2 issues with the old notifications:

  • We can not update the text of a notification once it got created.
  • We had several complains because people do not understand how it works underneath. And if you have only a short gap between the rounds it can be very tricky to catch it.

@caco3
Copy link
Collaborator Author

caco3 commented Dec 29, 2023

@Slider0007 I failed to reproduce the crash. I even bombarded the REST API with the editflow and statusflow calls but it never crashed. Can you find a way to reproducible crash it?

@Slider0007
Copy link
Collaborator

Slider0007 commented Dec 30, 2023

@Slider0007 I failed to reproduce the crash. I even bombarded the REST API with the editflow and statusflow calls but it never crashed. Can you find a way to reproducible crash it?

I opened the page and immediately pushed a button before page was fully loaded. I tested it twice just to make sure it was not a single event. Maybe only on my side and also not a realistic case. Just stressed it because it's new...

Anyway, go ahead with your approach.

@jomjol
Copy link
Owner

jomjol commented Dec 31, 2023

A good idea, I push this into rolling and see if others see this failure, too.

@jomjol jomjol merged commit a11e19f into rolling Dec 31, 2023
12 checks passed
@caco3 caco3 deleted the enhance-busy-notification branch January 31, 2024 19:51
caco3 added a commit that referenced this pull request Feb 2, 2024
* update

* Revert "v15.4.0"

This reverts commit 74d4f20.

* Revert "prepare v15.4.0 versuch 2"

This reverts commit e790a14.

* revert submnodules (#2768)

Co-authored-by: CaCO3 <[email protected]>

* Update submodules (#2769)

- Update `esp-nn` to v1.0.2
- Update `esp32-camera` to v2.0.6
- Updated `tflite-micro-esp-examples` (The repo got renamed to `esp-tflite-micro ` and the folder structure got cleaned up).

* fix(unity-test): Run unity tests in dedicated task
Avoid running out of heap

* Add delay

* Update

* Update

* Enhance busy notification (#2774)

* on marker updating, show message and retry until round got completed

* same for contrast enhancement

---------

Co-authored-by: CaCO3 <[email protected]>

* Fix negatives on extended resolution false #2744 (#2772)

* not extended resolution allows -1 on the lowest digit

* not extended resolution allows -1 on the lowest number

* negatives on last value digit with -1 will set to prevalue and is not an error  #2744

---------

Co-authored-by: jomjol <[email protected]>

* Implemented late analog / digital transition (#2778)

* Implemented late transition

Complete rewrite of analog / digital transition

Two tests is still failing, which need to be discussed.

* Allow wider range of transition values to support late transition

* Added documentation

* Fix testings (#2783)

* fix all tests and more description

* The decimal point offset. -3 corresponds to x.yyy

---------

Co-authored-by: jomjol <[email protected]>

* Bugfix InfluxDB shifting times (#2785)

* Modify time_sntp

* Update time_sntp.cpp

* Update time_sntp.cpp

* update

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update time_sntp.cpp

* Upload

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Remove Time Convert vom influx Interface

* Update platform-espressif32 to 6.5.0 (#2770)

* Update ESP IDF to 6.5.0

* Migration to new IDF

* Correct smtp vor v5.1

---------

Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: jomjol <[email protected]>

* ATA-Trim support (#2781)

* Add files via upload

* Update main.cpp

* Update main.cpp

* Update main.cpp

* Update Helper.cpp

* Update Helper.h

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update diskio_sdmmc_mh.c

* Update diskio_sdmmc_mh.h

* Update ff_mh.c

* Update vfs_fat_sdmmc_mh.c

* Update sdmmc_common_mh.h

* Update sdmmc_common_mh.c

* Update Helper.cpp

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update ff_mh.c

---------

Co-authored-by: CaCO3 <[email protected]>

* Update Changelog.md

* Add device info info page (#2789)

Signed-off-by: Florian Grabmeier <[email protected]>

* fix chip information REST API

* Update pipelines to fix warnings (#2841)

Update actions

* Move param doc (#2843)

moved param doc from docs repo to here

* fix(tflite): Fix memory leaks in tflite integration (#2842)

* Update Changelog.md (#2849)

---------

Signed-off-by: Florian Grabmeier <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: Martin Siggel <[email protected]>
Co-authored-by: michael <[email protected]>
Co-authored-by: flox_x <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
@caco3 caco3 mentioned this pull request Feb 2, 2024
caco3 added a commit that referenced this pull request Feb 2, 2024
* update

* Revert "v15.4.0"

This reverts commit 74d4f20.

* Revert "prepare v15.4.0 versuch 2"

This reverts commit e790a14.

* revert submnodules (#2768)



* Update submodules (#2769)

- Update `esp-nn` to v1.0.2
- Update `esp32-camera` to v2.0.6
- Updated `tflite-micro-esp-examples` (The repo got renamed to `esp-tflite-micro ` and the folder structure got cleaned up).

* fix(unity-test): Run unity tests in dedicated task
Avoid running out of heap

* Add delay

* Update

* Update

* Enhance busy notification (#2774)

* on marker updating, show message and retry until round got completed

* same for contrast enhancement

---------



* Fix negatives on extended resolution false #2744 (#2772)

* not extended resolution allows -1 on the lowest digit

* not extended resolution allows -1 on the lowest number

* negatives on last value digit with -1 will set to prevalue and is not an error  #2744

---------



* Implemented late analog / digital transition (#2778)

* Implemented late transition

Complete rewrite of analog / digital transition

Two tests is still failing, which need to be discussed.

* Allow wider range of transition values to support late transition

* Added documentation

* Fix testings (#2783)

* fix all tests and more description

* The decimal point offset. -3 corresponds to x.yyy

---------



* Bugfix InfluxDB shifting times (#2785)

* Modify time_sntp

* Update time_sntp.cpp

* Update time_sntp.cpp

* update

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update time_sntp.cpp

* Upload

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Update interface_influxdb.cpp

* Remove Time Convert vom influx Interface

* Update platform-espressif32 to 6.5.0 (#2770)

* Update ESP IDF to 6.5.0

* Migration to new IDF

* Correct smtp vor v5.1

---------




* ATA-Trim support (#2781)

* Add files via upload

* Update main.cpp

* Update main.cpp

* Update main.cpp

* Update Helper.cpp

* Update Helper.h

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update diskio_sdmmc_mh.c

* Update diskio_sdmmc_mh.h

* Update ff_mh.c

* Update vfs_fat_sdmmc_mh.c

* Update sdmmc_common_mh.h

* Update sdmmc_common_mh.c

* Update Helper.cpp

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update ff_mh.c

---------



* Update Changelog.md

* Add device info info page (#2789)



* fix chip information REST API

* Update pipelines to fix warnings (#2841)

Update actions

* Move param doc (#2843)

moved param doc from docs repo to here

* fix(tflite): Fix memory leaks in tflite integration (#2842)

* Update Changelog.md (#2849)

---------

Signed-off-by: Florian Grabmeier <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: Martin Siggel <[email protected]>
Co-authored-by: michael <[email protected]>
Co-authored-by: flox_x <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants