Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make check
, clang is much fussier about the order of header includes than gcc is. It complains about the use ofoperator<<
in scope/test when both scope/test.h and pair_out.h are included in a couple of test source files. It discovers the use of pair_out.h'soperator<<
in the test's use of a scope/test function, but scope/test is included before pair_out.h, so it complains that that definition ofoperator<<
is in the wrong place. It seems to be in the family of issues detailed at http://clang.llvm.org/compatibility.html#dep_lookup.Also, in one file, a std::vector was used without
#include <vector>
. I don't know how gcc was compiling that.