forked from ros-industrial-attic/reuleaux
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noetic Updates Associated With reuleaux_moveit Pull Request 8 #4
Open
MShields1986
wants to merge
62
commits into
jontromanab:master
Choose a base branch
from
MShields1986:noetic-devel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this `catkin build map_creator` fails. With this and running the following, I had all necessary dependency got resolved: ``` cd %YOUR_CATKIN_WS% rosdep install -r -y --from-paths src --ignore-src ```
[Metapackage](http://www.ros.org/reps/rep-0142.html) is commonly added to a ROS-based package suite where multiple packages are in. It allows to specify a single package upon build, e.g. `catkin build reuleaux`, and it's always good for people to access the single point of entry for the package.
Add a config file for Travis CI, for automated testing. Please see more about what can be checked [doc](https://github.com/ros-industrial/industrial_ci/blob/master/README.rst). Testcases might be not yet added to the packages here but at minimum we can check if pkgs build, dependency clearance etc. If this LGTY, any admins could enable Travis (at something like https://travis-ci.org/profile/ros-industrial-consortium) by a single click to get the checking started.
…ualization Robot visualization
…as those fixed already in the map_creator
Update with ROS-I Trunk
This is now up to date with the ROS-I master's latest commit also so we could PR to there also, once we are happy with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for Noetic needed for usage with reuleaux_moveit PR8.
I have not tested this fork for map creation as I ran into issues building OpenRAVE and for my work I needed to use MoveIt. It would be good if someone could test the functionality of this branch for map creation using OpenRAVE.