Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[5.2] Load the namespace from the cached manifest" #44755

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 19, 2025

Reverts #44737

Reverting changes. For a few reasons:

  • Loading a few bytes for nothing (in my test it add +100μs time to each request)
  • The core does not read namespace from Db and we should not.

The PR for property deprecation #44754

If we need access to extension NS we need to plan a better API.
Currently I cannot sugest anything better, but having it like in the PR is not a good thing.

@HLeithner HLeithner merged commit 7647896 into 5.2-dev Jan 20, 2025
3 of 5 checks passed
@laoneo laoneo deleted the revert-44737-5.2/bugfix/missing-namespace branch January 20, 2025 08:22
@laoneo
Copy link
Member

laoneo commented Jan 20, 2025

Thanks!!

@pe7er pe7er added this to the Joomla! 5.2.4 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants