Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pagination and responsivness #62

Merged
merged 1 commit into from
Jun 8, 2024
Merged

added pagination and responsivness #62

merged 1 commit into from
Jun 8, 2024

Conversation

StanislawMalinski
Copy link
Collaborator

No description provided.

@StanislawMalinski StanislawMalinski marked this pull request as ready for review May 30, 2024 11:22
jordus100
jordus100 requested changes May 30, 2024
View reviewed changes
Copy link
Owner

@jordus100 jordus100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoko, ale do doszlifowania, bo leaderboard wypełnia tylko pół ekranu:
image
Poza tym skoro już jesteśmy przy paginatorze to fajnie by naprawić wyskakujące cyferki w miarę możliwości.

@jordus100
Copy link
Owner

a i po kliknięciu w leaderboarda wywala error

@StanislawMalinski StanislawMalinski marked this pull request as draft May 30, 2024 20:45
@StanislawMalinski
Copy link
Collaborator Author

dodałem fix'a

@StanislawMalinski StanislawMalinski marked this pull request as ready for review May 30, 2024 21:04
jordus100
jordus100 requested changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@jordus100 jordus100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paginacja wygląda teraz super, ale leaderboard nadal jest zbyt mały bez powodu

jordus100
jordus100 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Owner

@jordus100 jordus100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kozak, nawet jest responsywne

@jordus100 jordus100 merged commit efa2028 into master Jun 8, 2024
1 check passed
@jordus100 jordus100 deleted the leaderboard_view branch June 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordus100 jordus100 jordus100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanislawMalinski @jordus100