Implement rudimentary compatibility with jedi 18.0 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR implements basic compatibility with jedi 18.0. The issue was that the default json serializer used by python json.dumps could not handle
pathlib.Pathobjects. This PR addresses the issue by extending the default JSONEncoder class.pathlib.Pathobjects are converted to str before encoding them to json.PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
Test are not really passing BUT the tests were not passing before this change anyway. At least some more tests are passing now.