-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export type test helpers #163
base: master
Are you sure you want to change the base?
Conversation
I have no strong opinion - @josephg looks ok? |
I've also included types.helpers here so bootstrapTransform can be used on the server. (It's only currently available in the browser as |
I'm confused - why is randomWord imported in each type's tests? |
This patch confuses me.
And also, the OT types have moved into their own project. Once you're happy with it, this pull request will need to be duplicated to josephg/ot-types . |
Ahah – I didn't see the ot-types project before. That's pretty cool. I moved randomWord into test/helpers/misc just for the sake of organising it. Would it be better in a separate file? Would you prefer everything to be exposed as |
Yeah Moving forward, I'm not really sure how these projects should be hooked up. I guess the ot types project should expose the randomizer and bootstrapTransform functions directly. If people want to use them from sharejs, they can just |
... so they can be used for testing custom types. See #156