Fix bug with Globalize::ActiveRecord#attributes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from globalize cache instead of Model's attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation causes attributes to be fetched from globalize's cache instead of the model's attributes. When a value for an attribute is false, then the cache is checked causing a return of nil instead of false. The end result can cause validation errors when inserting records into the database. This patch first checks to see whether the attribute is set on the model. If it is set, the value is returned, otherwise it returns the value from globalize's attribute cache.
Globalize::ActiveRecord#reload is also patched to play nicely with alias_method_chain from other plugins.