Fix Django 1.10 and 2.0 compatibility #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrs83
commented
Mar 20, 2018
mrs83
commented
- Handle "aggregate_select" deprecated method from django.db.sql.query.Query.
- Make "reverse" import compatible for both versions 1.10 and 2.0.
- Handle "aggregate_select" deprecated method from django.db.sql.query.Query. - Import "reverse" compatible with both versions 1.10 and 2.0.
stianpr
reviewed
Apr 5, 2018
django_tablib/datasets.py
Outdated
|
|
||
| if hasattr(v_qs.query, 'aggregate_select'): | ||
| # Django < 1.10 | ||
| headers.extend(v_qs.query.aggregate_select) |
There was a problem hiding this comment.
Well, it has been renamed AFAICS. So we should still use it for >= 1.10, but with the name annotation_select.
I'm not the owner of this repo, but it would be nice to get this PR in when updated.
mrs83
changed the title
mrs83
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.