Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect call to memset in app/memcmp, causing UB #84

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix the incorrect call to memset in app/memcmp, causing UB #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bd6f0c
Fix the incorrect call to memset in app/memcmp, causing undefined beh…
Aug 26, 2024
619a124
Fix another memset causing UB
Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/aep-redirect/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ void attacker_config_page_table(void) {
print_pte_adrs(code_pt);

/* Specify #PF handler with signinfo arguments */
memset(&act, sizeof(sigaction), 0);
memset(&act, 0, sizeof(sigaction));
act.sa_sigaction = fault_handler;
act.sa_flags = SA_RESTART | SA_SIGINFO;

Expand Down
2 changes: 1 addition & 1 deletion app/memcmp/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ void register_signal_handler(int signo)
struct sigaction act, old_act;

/* Specify #PF handler with signinfo arguments */
memset(&act, sizeof(sigaction), 0);
memset(&act, 0, sizeof(sigaction));
act.sa_sigaction = fault_handler;
act.sa_flags = SA_RESTART | SA_SIGINFO;

Expand Down
Loading