Skip to content

Commit

Permalink
Made crate level visible the BaseOpenAIClientMethods trait
Browse files Browse the repository at this point in the history
  • Loading branch information
jpalvarezl committed Sep 18, 2024
1 parent 5878362 commit 4659362
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/openai/inference/src/clients/azure_openai_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use azure_core::{BearerTokenCredentialPolicy, Url};
use super::chat_completions_client::ChatCompletionsClient;
use super::BaseOpenAIClientMethods;

pub trait AzureOpenAIClientMethods: BaseOpenAIClientMethods {
pub trait AzureOpenAIClientMethods {
fn new(
endpoint: impl AsRef<str>,
credentials: Arc<dyn TokenCredential>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub struct ChatCompletionsClient {
}

impl ChatCompletionsClient {
pub fn new(base_client: Box<dyn BaseOpenAIClientMethods>) -> Self {
pub(crate) fn new(base_client: Box<dyn BaseOpenAIClientMethods>) -> Self {
Self { base_client }
}
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/openai/inference/src/clients/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub use azure_openai_client::{AzureOpenAIClient, AzureOpenAIClientMethods};
pub use chat_completions_client::{ChatCompletionsClient, ChatCompletionsClientMethods};
pub use openai_client::{OpenAIClient, OpenAIClientMethods};

pub trait BaseOpenAIClientMethods {
pub(crate) trait BaseOpenAIClientMethods {
fn base_url(&self, deployment_name: Option<&str>) -> azure_core::Result<azure_core::Url>;

fn pipeline(&self) -> &azure_core::Pipeline;
Expand Down

0 comments on commit 4659362

Please sign in to comment.