Various visibility restrictions

jpalvarezl · Sep 19, 2024 · f3795a1 · f3795a1
1 parent 8651661
commit f3795a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/sdk/openai/inference/src/clients/chat_completions_client.rs b/sdk/openai/inference/src/clients/chat_completions_client.rs
@@ -28,7 +28,7 @@ pub struct ChatCompletionsClient {
 }
 
 impl ChatCompletionsClient {
-    pub(crate) fn new(base_client: Box<dyn BaseOpenAIClientMethods>) -> Self {
+    pub(super) fn new(base_client: Box<dyn BaseOpenAIClientMethods>) -> Self {
         Self { base_client }
     }
 }

diff --git a/sdk/openai/inference/src/clients/mod.rs b/sdk/openai/inference/src/clients/mod.rs
@@ -8,7 +8,7 @@ pub use azure_openai_client::{AzureOpenAIClient, AzureOpenAIClientMethods};
 pub use chat_completions_client::{ChatCompletionsClient, ChatCompletionsClientMethods};
 pub use openai_client::{OpenAIClient, OpenAIClientMethods};
 
-pub(crate) trait BaseOpenAIClientMethods {
+trait BaseOpenAIClientMethods {
     fn base_url(&self, deployment_name: Option<&str>) -> azure_core::Result<azure_core::Url>;
 
     fn pipeline(&self) -> &azure_core::Pipeline;
@@ -18,17 +18,12 @@ fn new_pipeline(
     per_call_policies: Vec<Arc<dyn azure_core::Policy>>,
     options: azure_core::ClientOptions,
 ) -> azure_core::Pipeline {
-    let crate_name = option_env!("CARGO_PKG_NAME");
-    let crate_version = option_env!("CARGO_PKG_VERSION");
-    // should I be using per_call_policies here too or are they used by default on retries too?
-    let per_retry_policies = Vec::new();
-
     azure_core::Pipeline::new(
-        crate_name,
-        crate_version,
+        option_env!("CARGO_PKG_NAME"),
+        option_env!("CARGO_PKG_VERSION"),
         options,
         per_call_policies,
-        per_retry_policies,
+        Vec::new(),
     )
 }