forked from Azure/azure-sdk-for-rust
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff tracker PR rebased on feature/track2
fork
#2
Draft
jpalvarezl
wants to merge
83
commits into
jpalvarezl/feature/track2
Choose a base branch
from
jpalvarezl/aoai_from_track2
base: jpalvarezl/feature/track2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Diff tracker PR rebased on feature/track2
fork
#2
jpalvarezl
wants to merge
83
commits into
jpalvarezl/feature/track2
from
jpalvarezl/aoai_from_track2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalvarezl
force-pushed
the
jpalvarezl/aoai_from_track2
branch
2 times, most recently
from
September 13, 2024 12:30
23770c0
to
074e5ee
Compare
* AMQP changes for C++ Connection support * Export uuid directly from AMQP * cleaned up export of Uuid * wasm fix
* Removed unsupported or undesirable credentials Fixes Azure#1805 by removing unused flows (we'll use the remaining flows internally) and fixes Azure#1806 by removing support for `azureauth`. * Fix lint issues * Fix lint issues against +stable * Fix docs * Resolve merge conflict in cosmos * Rename azure_core::auth to azure_core::credentials * Fix fmt issue * Fix doc reference * Fix wasm32 build
…zure#1808) * Add pre-reqs and tasks for launching a live version of the docs site * disable spell-check on some files * Build all features and set 'docsrs' flag to enable docs related features in crates
* Remove ClientSecretCredential, EnvironmentCredential Also moves SpecificAzureCredential to a sample. Fixes Azure#1812. * Use DAC constructor instead of factory function Also fixes a few lints * Fix doc tests
…iner (Azure#1814) * add container_client and ContainerClient::read * rudimentary initial query API * re-do partition keys to hide serde_json * switch to a `NullValue` marker shared by query and partition key, and update docs * add tracing_subscriber with env filter to all cosmos examples * fix doctests * remove Send bound from WASM * Add 'Sync' bound to from_response_body, but exclude bounds from wasm32 * copyright headers, copyright headers everywhere * change Pageable back to an owning type * pr feedback * refactor partition_key parameter to partition_key_strategy * refmt and move helper back to azure_data_cosmos * fix docs * remove unnecessary doctest from internal utility * fix cosmos_query sample * simplify doctests that don't run using panic!()
* POC 1 * Slightly closer, would like to move out of Arc and towards RwLock * Refactor * Nits * Move to RwLock since this scenario doesn't need mutex * Unused import Cargo.toml * No unwrap, return azure_core::Result, async RwLock, tested in playground * Remove unnecessary as_ref * PR feedback * Refactor access_token() to return Option, final nit how to handle option on send() * Nit * Remove unwrap(), add back in explicit drop() since async_lock::RwLock seems to hang on read lock when trying to acquire writer lock
* complete session implemetnation; C++ related changes * Removed lots of .unwraps * auth->credentials * Removed most instances of .unwrap from eventhubs and amqp
…zure#1828) * Always return `Result<Arc<Self>>` from `new` credential constructors Resolves Azure#1825. Also cleans up a few clippy warnings since I was running running clippy over the entire workspace. * Fix Cosmos test * Update README with reasoning for `Result<Arc<Self>>`
Co-authored-by: Heath Stewart <[email protected]>
jpalvarezl
force-pushed
the
jpalvarezl/aoai_from_track2
branch
from
September 30, 2024 13:11
f00dd19
to
a82e472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.