Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the option to specify a result file with --move VIEW #2075

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Added the option to specify a result file with --move VIEW #2075

wants to merge 6 commits into from

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Nov 20, 2024 •
edited by tsaglam
Loading

Added the option to specify a result file with --mode VIEW

Allows to specify exactly one file with either the positional argument, --new, --old or -r

The documentation has been adapted in the CLI and in the README

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Nov 22, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Nov 22, 2024
@sonarqubecloud SonarQubeCloud

This comment was marked as outdated.

Sign in to view
tsaglam
tsaglam requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor issues (+ Sonar issues).

cli/src/main/java/de/jplag/cli/options/CliOptions.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/picocli/CliInputHandler.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/picocli/CliInputHandler.java Outdated Show resolved Hide resolved
@Kr0nox Kr0nox mentioned this pull request Jan 31, 2025
Open
@TwoOfTwelve
Copy link
Contributor Author

The documentation still has to be adapted, but since that conflicts with #2168, I'll do that once that one is merged.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoOfTwelve @tsaglam