Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in GCC and VC #1161

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Warnings in GCC and VC #1161

merged 2 commits into from
Dec 11, 2023

Conversation

Thrameos
Copy link
Contributor

This PR deals with warnings that are currently triggering in VC and GCC.

  • Local variables not used on exception catches
  • Mismatched types between primitives requiring casts
  • A throw path on extern "C" that must not be allowed to propagate or it will trigger a segfault.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4471a27) 87.49% compared to head (9d5d399) 87.44%.

Files Patch % Lines
native/common/jp_proxy.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
- Coverage   87.49%   87.44%   -0.05%     
==========================================
  Files         113      113              
  Lines       10233    10236       +3     
  Branches     4057     4057              
==========================================
- Hits         8953     8951       -2     
- Misses        688      692       +4     
- Partials      592      593       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thrameos Thrameos merged commit 0c50910 into master Dec 11, 2023
25 of 27 checks passed
@marscher marscher deleted the warnings branch September 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant