Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpress: set banner via php env var #64

Merged
merged 2 commits into from
Oct 13, 2024
Merged

wordpress: set banner via php env var #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ddc13
wordpress: set banner via php env var
timmywil Oct 8, 2024
e5559b1
fixup! make banner message actionable (upgrade to prepare)
timmywil Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/profile/templates/wordpress/docs/jquery-config.php.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,10 @@ define( 'JQUERY_STAGING_FORMAT', 'stage.%s' );
if ( defined( 'XMLRPC_REQUEST' ) ) {
@ini_set( 'memory_limit', '512M' );
}

<%- if @live_site == 'jquery.com' || @live_site == 'api.jquery.com' -%>
define(
'JQUERY_BANNER',
'jQuery 4.0 is coming soon! Prepare by <a href="https://jquery.com/download/">upgrading</a> to the latest jQuery 3.x release. Learn more about our <a href="https://jquery.com/support/">version support</a>.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best way to prepare would be to update to the latest jQuery 3.x, enable Migrate for a while and make sure no warnings are being issued.

One problem with this approach, though, is adding Migrate will also reintroduce jQuery 1.9 behavior in many APIs which is undesirable. I have an issue to tackle this problem in Migrate: jquery/jquery-migrate#472.

For now, this is good, I think.

);
<%- end -%>