Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths in stylesheets #857

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

mattiasb
Copy link
Contributor

@mattiasb mattiasb commented Nov 16, 2024

Description

Resolve style sheets in markdown-css-paths relative to the Markdown file

This fixes loading of "./stylesheet.css" from #834.

Related Issue

#855

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@mattiasb
Copy link
Contributor Author

Rebased and used the correct issue number (#855) in CHANGES.md.

@mattiasb
Copy link
Contributor Author

mattiasb commented Nov 17, 2024

Using concat over file-name-concat seems like an okay workaround for Emacs 27 FWIW.

But I don't know if one can rely on default-directory always ending with a /.

EDIT: Nevermind, I'm stupid. Since it's in a unit test we control all in data so we don't need to bother with this hypothetical.

@mattiasb mattiasb force-pushed the feature/relative-css-paths branch from 6806e48 to 28dad26 Compare November 17, 2024 12:58
@syohex syohex merged commit e3e11c4 into jrblevin:master Nov 17, 2024
4 checks passed
@mattiasb mattiasb deleted the feature/relative-css-paths branch November 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants