Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Servo][Spinal][Neuron] refactor the rule to handle pulley skip with external encoder #666

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

tongtybj
Copy link
Collaborator

What is this

Do not permanently disable servo of which the pulley is skipped, since this action is very dangerous for flying. So, update the new internal offset by using the angles from both internal and external encoders.

Details

  • The error flag of pulley skip does not lead to the servo disable.
  • The error flag of pulley skip only lasts for the duration of s->pulley_skip_time_ (i.e., 1000ms).
  • After s->pulley_skip_time_, the internal_offset_ will be updated, and error flag will be cleared.

tongtybj and others added 5 commits January 22, 2025 22:02
…n spinal and neuron while switch the servo torque on/off. Especially avoid the chattering just after servo on by using the raw position value of servo internal encoder.
…p. No servo off process. Reset the internal offset and the target angle
…r bit to avoid joint servo off (e.g., the pulley skip error and the overload error)
@tongtybj tongtybj merged commit 7be81c8 into jsk-ros-pkg:master Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant