Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LC_ALL variable to action.yml #440

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

iory
Copy link
Member

@iory iory commented Apr 20, 2022

What is this?

This PR allows the environment variable LC_ALL to be passed during catkin build.
Some python library requires LC_ALL to be set.
This issue occurs when installing a python library with catkin virtualenv and when installing dependent libraries from some.
This PR fix test for the following PRs.
jsk-ros-pkg/jsk_3rdparty#326
jsk-ros-pkg/jsk_3rdparty#337

@iory iory force-pushed the utf-8 branch 2 times, most recently from d156716 to 04869d2 Compare April 22, 2022 00:38
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iory please check if this really works, I think we need path this environment variable to docker, so please add test something like #444

@iory
Copy link
Member Author

iory commented May 2, 2022

Thank you for your comment.
I merged the test commit and passthrough the LC_ALL variable to docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants