Merge master into openapi #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct derived type must be available in `QueryLayer.Selection`, which wasn't the case. Parsing of include chains is changed to include relationships on all concrete derived types. For example, given an inclusion chain of "wheels" at `/vehicles`, the parser now returns `Car.Wheels` and `Truck.Wheels`. This used to be `Vehicle.Wheels`. There's no point in adding abstract types, because they can't be instantiated in selectors. `QueryLayerComposer` was fixed to generate selectors for the left-type of these relationships, instead of for the `QueryLayer` resource type (so `Car.Wheels` and `Truck.Wheels` instead of `Vehicle.Wheels`). `SelectClauseBuilder` was missing a cast to the derived type when descending into relationship selectors, which is fixed now. Being unable to include relationships of sibling types after a POST/PATCH resource request at a base endpoint was because a `QueryLayer` for fetch-after-post was built against the accurized resource type, and then sent to the original (non-accurized) repository. For example, `POST /vehicles?include=TruckRelationship,CarRelationship` only works if the query executes against the non-accurized table (so `Vehicle` instead of `Car`, because `Car` doesn't contain `TruckRelationship`). The fix is to discard the accurized resource type and use the original `TResource`. Other improvements: - During the process of building expression trees, consistency checks have been added to prevent downstream crashes that are difficult to diagnose. - `SelectClauseBuilder` internally passed along a `LambdaScope` that overruled the one present in context, so care had to be taken to use the right one. To eliminate this pitfall, now a new context is forked which contains the appropriate `LambdaScope`, so the overruling parameter is no longer needed. Fixes #1639, fixes #1640.
- Turn off scanning for vulnerable dependencies in downstream packages - Turn off warning when targeting NETSTANDARD 1.x
Resource inheritance fixes
…sed to workaround NSwag bug in OpenAPI) (#1644)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## openapi #1645 +/- ##
===========================================
- Coverage 90.50% 90.46% -0.05%
===========================================
Files 459 459
Lines 13915 13938 +23
Branches 2156 2166 +10
===========================================
+ Hits 12594 12609 +15
- Misses 897 903 +6
- Partials 424 426 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the master branch into openapi, which provides fixes for resource inheritance.