Add @NonNull annotations to @NullUnmarked APIs.
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While [we're not sure about the attribute values](#10 (review)), we believe that everything else is non-null. I hadn't thought of using `@NonNull` back then, but it occurred to me after I put together #109.
wmdietl
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
When looking at the second signature, I nearly missed that the second type argument is the only type that is null-unmarked.
Adding the comments makes that more explicit, without a separate type-use annotation.
But it is also more verbose... I'm fine either way.
Co-authored-by: Werner Dietl <[email protected]>
|
Thanks for all the reviews! I got to wondering if it would be clearest to use a comment like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're not sure about the attribute
values,
we believe that everything else is non-null.
I hadn't thought of using
@NonNullback then, but it occurred to meafter I put together #109.