Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate some recent io APIs. #113

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Annotate some recent io APIs. #113

merged 2 commits into from
Dec 18, 2024

Conversation

cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Dec 10, 2024

In Console, I had annotated the parameter of readln previously but
missing the return type. Then the JDK added an overload whose return
type also needs an annotation.

Along the way, I noticed similar methods in the IO class, so I
annotated it, too.

In `Console`, I had annotated the parameter of `readln` previously but
missing the return type. Then the JDK added an overload whose return
type also needs an annotation.

Along the way, I noticed similar methods in the `IO` class, so I
annotated it, too.
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All matches the javadocs.

@wmdietl wmdietl assigned cpovirk and unassigned wmdietl Dec 18, 2024
@cpovirk cpovirk merged commit e07b421 into main Dec 18, 2024
19 checks passed
@cpovirk cpovirk deleted the newio branch December 18, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants