Annotate the new repeat API on StringBuilder and friends.
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure that annotation in `AbstractStringBuilder` matter much, but I'm not ruling it out that an expression could have that implicit type if you wrote something like `b ? new StringBuilder() : new StringBuffer()`. And anyway, it was nice to keep `AbstractStringBuilder` up to date while having reference to its implementation so that I could then easily cross-reference between it and the subclasses.
kluever
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that annotation in
AbstractStringBuildermatter much, butI'm not ruling it out that an expression could have that implicit type
if you wrote something like
b ? new StringBuilder() : new StringBuffer(). And anyway, it was nice to keepAbstractStringBuilderup to date while having reference to its implementation so that I could
then easily cross-reference between it and the subclasses.