Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume a single conformance test ZIP #115

Merged
merged 27 commits into from
Dec 11, 2023

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Dec 5, 2023

Depends on jspecify/jspecify#422.

@netdpb
Copy link
Collaborator Author

netdpb commented Dec 11, 2023

I'm having trouble here. On my local machine, the tests pass. On the GitHub action, they fail because when analyzing UsesDep.java, Checker Framework reports:

UsesDep.java:21 (type.checking.not.run) NullSpecChecker did not run because of a previous error issued by javac
    public class UsesDep {
           ^

This error does not occur on my local machine (running with JDK 11 or JDK 17; GitHub's action uses JDK 17).

However, no previous error appears in the output.

@netdpb
Copy link
Collaborator Author

netdpb commented Dec 11, 2023

OK, I figured it out.

@netdpb
Copy link
Collaborator Author

netdpb commented Dec 11, 2023

The problem was that I tried to add system properties with the files extracted from the ZIP in Gradle's configuration phase, which runs while the task graph is being set up. Those files don't appear until the execution phase, which is what actually runs for a task after the tasks it depends on have run.

Setting the system properties in doBefore blocks did the trick.

@netdpb netdpb requested a review from cpovirk December 11, 2023 21:00
Copy link
Collaborator

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I helpfully see nothing wrong with this version, just as I helpfully saw nothing wrong with the previous version!

@netdpb netdpb merged commit d80cf8a into jspecify:main Dec 11, 2023
2 checks passed
@netdpb netdpb deleted the conformance-test-artifact branch December 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants