-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume a single conformance test ZIP #115
Conversation
… and start depending on the conformance test artifact.
… and a regular jar containing compiled dependencies.
…er-framework into conformance-test-artifacts
…er-framework into conformance-test-artifact
…er-framework into conformance-test-artifact
…er-framework into conformance-test-artifact
I'm having trouble here. On my local machine, the tests pass. On the GitHub action, they fail because when analyzing
This error does not occur on my local machine (running with JDK 11 or JDK 17; GitHub's action uses JDK 17). However, no previous error appears in the output. |
…, not the configuration phase. Also, setting up the unzip task itself as the inputs means we don't have to depend explicitly on the task.
OK, I figured it out. |
The problem was that I tried to add system properties with the files extracted from the ZIP in Gradle's configuration phase, which runs while the task graph is being set up. Those files don't appear until the execution phase, which is what actually runs for a task after the tasks it depends on have run. Setting the system properties in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I helpfully see nothing wrong with this version, just as I helpfully saw nothing wrong with the previous version!
Depends on jspecify/jspecify#422.