Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust active nav item highlight #51

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: adjust active nav item highlight #51

merged 2 commits into from
Feb 28, 2024

Conversation

donjo
Copy link
Member

@donjo donjo commented Feb 28, 2024

Gives the nav item a style that is differentiated from the hover state and anchors it to the subnav bottom border.

Removes subnav bottom border in mobile viewport.

Unrelated but also removes some arbitrary padding on the divider in the header that was making "sign in with github" look weird.

Screenshot 2024-02-28 at 3 29 27 PM Screenshot 2024-02-28 at 3 29 09 PM

Copy link
Contributor

@josh-collinsworth josh-collinsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Luca's got a fix for that linter issue In CI here, so as soon as it merges you should be good after rebasing. [Edit: or you could just apply the same change if you don't want to wait.]

@donjo donjo enabled auto-merge February 28, 2024 22:00
@donjo donjo added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 27fb183 Feb 28, 2024
5 checks passed
@donjo donjo deleted the johnd/nav-updates branch February 28, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants