Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf, a11y and SEO improvements #52

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Perf, a11y and SEO improvements #52

merged 3 commits into from
Feb 29, 2024

Conversation

josh-collinsworth
Copy link
Contributor

@josh-collinsworth josh-collinsworth commented Feb 28, 2024 •
edited
Loading

Perf

  • Defer particles script
  • Preload fonts

Accessibility

  • Fix up ARIA roles and attributes on package search
  • Correct some contrast issues
  • Fix a missing alt

SEO

  • Add description meta tag
  • Add OG share image (open to feedback)
  • Fix title of score page

@josh-collinsworth josh-collinsworth changed the title Perf, SEO, and a11y improvements Perf, a11y and SEO improvements Feb 28, 2024
ry
ry reviewed Feb 29, 2024
View reviewed changes
frontend/static/images/og-image.webp
Copy link
Contributor

@ry ry Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github, why can't you display this?!

Copy link
Contributor

@ry ry Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-29 at 1 03 46 AM

ry
ry approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the h1 to match the og-image?
"An open-source package registry for modern JavaScript and TypeScript"

@lucacasonato lucacasonato added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 78673ef Feb 29, 2024
5 checks passed
@lucacasonato lucacasonato deleted the joco/lighthouse branch February 29, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josh-collinsworth @ry @lucacasonato