Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attributes for brevo #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ammannbe
Copy link

@ammannbe ammannbe commented Sep 7, 2023

First, thank you for this plugin!

I opened this PR to allow custom attributes for the brevo integration.
The field can dynamically provided by the frontend, or left away completely.

@juban
Copy link
Owner

juban commented Sep 22, 2023

Hi @ammannbe
Thank you for your PR which looks good.
I'll take a look as soon as possible.

@juban juban self-assigned this Sep 22, 2023
@juban
Copy link
Owner

juban commented Nov 25, 2023

Hi @ammannbe

Sorry for the delay.
Based on your PR, I would like to give the feature a more "provider agnostic" approach.
I'm in the process of adding the "additional fields" capability to both Mailchimp and Mailjet adapters.
I'll also have to adapt the tests in order to take the new feature into account and write according documentation.

Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants