-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide runtime enclosing instance types to ResourceLocksProviders #4267
Merged
marcphilipp
merged 8 commits into
main
from
marc/4163-resource-locks-provider-runtime-enclosing-types
Jan 26, 2025
Merged
Provide runtime enclosing instance types to ResourceLocksProviders #4267
marcphilipp
merged 8 commits into
main
from
marc/4163-resource-locks-provider-runtime-enclosing-types
Jan 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
requested changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLocksProvider.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLocksProvider.java
Show resolved
Hide resolved
...iter-engine/src/main/java/org/junit/jupiter/engine/descriptor/MethodBasedTestDescriptor.java
Outdated
Show resolved
Hide resolved
jupiter-tests/src/test/java/org/junit/jupiter/api/parallel/ResourceLocksProviderTests.java
Outdated
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/4163-resource-locks-provider-runtime-enclosing-types
branch
from
January 26, 2025 09:54
b2b5d42
to
c1fc7d1
Compare
sbrannen
requested changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the previous changes!
I've requested two minor Javadoc changes.
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLocksProvider.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLocksProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Brannen <[email protected]>
Co-authored-by: Sam Brannen <[email protected]>
Co-authored-by: Sam Brannen <[email protected]>
Co-authored-by: Sam Brannen <[email protected]>
marcphilipp
force-pushed
the
marc/4163-resource-locks-provider-runtime-enclosing-types
branch
from
January 26, 2025 18:09
467c641
to
4846127
Compare
marcphilipp
deleted the
marc/4163-resource-locks-provider-runtime-enclosing-types
branch
January 26, 2025 18:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4163.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotationsChange is documented in the User Guide and Release Notes