Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkernel_core::execute_request sets execution_count from reply #376

Merged
merged 1 commit into from
Dec 15, 2023
Merged

xkernel_core::execute_request sets execution_count from reply #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/xkernel_core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ namespace xeus
std::string code = content.value("code", "");
bool silent = content.value("silent", false);
bool store_history = content.value("store_history", true);
int execution_count = content.value("execution_count", 1);
store_history = store_history && !silent;
nl::json user_expression = content.value("user_expressions", nl::json::object());
bool allow_stdin = content.value("allow_stdin", true);
Expand All @@ -237,7 +236,7 @@ namespace xeus

nl::json reply = p_interpreter->execute_request(
code, silent, store_history, std::move(user_expression), allow_stdin);

int execution_count = reply.value("execution_count", 1);
std::string status = reply.value("status", "error");
send_reply("execute_reply", std::move(metadata), std::move(reply), c);

Expand Down
Loading